Skip to content

Symfony instrumentation - Add route name as HTTP_ROUTE attribute #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 24, 2023
Merged

Symfony instrumentation - Add route name as HTTP_ROUTE attribute #119

merged 1 commit into from
Feb 24, 2023

Conversation

piotrantosik
Copy link
Contributor

No description provided.

@piotrantosik piotrantosik requested a review from a team February 24, 2023 14:24
@welcome
Copy link

welcome bot commented Feb 24, 2023

Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one.

@codecov
Copy link

codecov bot commented Feb 24, 2023 •
edited
Loading

Codecov Report

Merging #119 (2067a5c) into main (6c0ef1a) will decrease coverage by 0.16%.
The diff coverage is 0.00%.

❗ Current head 2067a5c differs from pull request most recent head f7b6af0. Consider uploading reports for the commit f7b6af0 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #119      +/-   ##
============================================
- Coverage     52.97%   52.82%   -0.16%     
- Complexity      442      445       +3     
============================================
  Files            48       48              
  Lines          1678     1683       +5     
============================================
  Hits            889      889              
- Misses          789      794       +5
Flag Coverage Δ
7.4 81.76% <ø> (ø)
8.0 59.54% <0.00%> (-0.21%) ⬇️
8.1 59.61% <0.00%> (-0.21%) ⬇️
8.2 52.73% <0.00%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rumentation/Symfony/src/SymfonyInstrumentation.php 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c0ef1a...f7b6af0. Read the comment docs.

@bobstrecansky bobstrecansky merged commit 6088a1c into open-telemetry:main Feb 24, 2023
@piotrantosik piotrantosik deleted the ft/symfony-route branch February 25, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobstrecansky bobstrecansky bobstrecansky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piotrantosik @bobstrecansky