initial laravel auto instrumentation, root span, kernel::handle hook #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #116 +/- ##
============================================
- Coverage 55.21% 53.48% -1.73%
- Complexity 425 435 +10
============================================
Files 46 48 +2
Lines 1610 1662 +52
============================================
Hits 889 889
- Misses 721 773 +52
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
bobstrecansky
approved these changes
Feb 21, 2023
Contributor
|
One small CI failure, but everything else looks good! |
Member
Author
Yes, the problem is that it's inside laravel itself. Don't know if we can suppress that |
pdelewski
force-pushed
the
laravel-auto-instrumntation-1
branch
from
7bf2ddd to
bb703dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.