Skip to content

initial symfony auto instrumentation #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pdelewski merged 8 commits into from
Feb 21, 2023
Merged

initial symfony auto instrumentation #114

pdelewski merged 8 commits into from
Feb 21, 2023

Conversation

@pdelewski
Copy link
Member

@pdelewski pdelewski commented Feb 20, 2023 •
edited
Loading

Support for HttpKernel::handle method

@pdelewski pdelewski requested a review from a team February 20, 2023 12:09
@codecov
Copy link

codecov bot commented Feb 20, 2023 •
edited
Loading

Codecov Report

Merging #114 (c7eb240) into main (2070a38) will decrease coverage by 1.85%.
The diff coverage is 0.00%.

❗ Current head c7eb240 differs from pull request most recent head d1b4acb. Consider uploading reports for the commit d1b4acb to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #114      +/-   ##
============================================
- Coverage     57.06%   55.21%   -1.85%     
- Complexity      415      425      +10     
============================================
  Files            44       46       +2     
  Lines          1558     1610      +52     
============================================
  Hits            889      889              
- Misses          669      721      +52
Flag Coverage Δ
7.4 81.76% <ø> (ø)
8.0 61.91% <0.00%> (-2.34%) ⬇️
8.1 61.98% <0.00%> (-2.34%) ⬇️
8.2 55.12% <0.00%> (-1.85%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../Instrumentation/Symfony/src/HeadersPropagator.php 0.00% <0.00%> (ø)
...rumentation/Symfony/src/SymfonyInstrumentation.php 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2070a38...d1b4acb. Read the comment docs.

@pdelewski pdelewski mentioned this pull request Feb 20, 2023
Closed
@pdelewski pdelewski force-pushed the symfony-auto-instrumentation branch from b4063c8 to eae540a Compare February 20, 2023 15:26
@pdelewski pdelewski force-pushed the symfony-auto-instrumentation branch 3 times, most recently from 6568d55 to ecf8ed4 Compare February 20, 2023 19:25
@pdelewski pdelewski force-pushed the symfony-auto-instrumentation branch from ecf8ed4 to d1b4acb Compare February 20, 2023 19:30
@pdelewski pdelewski merged commit ae4c6a5 into open-telemetry:main Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettmc brettmc brettmc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pdelewski @brettmc