fixing wordpress autoinstrumentation span scopes #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling Span::activate() creates a debug scope which wraps the real scope, but the debug scope is not retrievable
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #107 +/- ##
=========================================
Coverage 64.42% 64.42%
Complexity 399 399
=========================================
Files 42 42
Lines 1380 1380
=========================================
Hits 889 889
Misses 491 491
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
bobstrecansky
approved these changes
Feb 7, 2023
bobstrecansky
approved these changes
Feb 7, 2023
pdelewski
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
Span::activate()creates a debug scope which wraps the real scope, but the debug scope is not retrievable. This causes wordpress auto-instrumented to complain about dangling debug scopes, even though the real scope was detached.The right way to do it is to
Context::storage()->attach()...