Skip to content

Conversation

@brettmc
Copy link
Contributor

@brettmc brettmc commented Jan 31, 2023

making core otel version requirements consistent, since some requirements were still ^0. Now, everything (except symfony) depends on ^1.0

making core otel version requirements consistent, since some requirements were still ^0. Now, everything (except symfony) depends on ^1.0
@brettmc brettmc requested a review from a team January 31, 2023 05:17
@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Merging #103 (5d95adb) into main (bf6bd88) will increase coverage by 21.00%.
The diff coverage is n/a.

❗ Current head 5d95adb differs from pull request most recent head a93f772. Consider uploading reports for the commit a93f772 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##               main     #103       +/-   ##
=============================================
+ Coverage     64.42%   85.42%   +21.00%     
+ Complexity      399      121      -278     
=============================================
  Files            42        9       -33     
  Lines          1380      350     -1030     
=============================================
- Hits            889      299      -590     
+ Misses          491       51      -440     
Flag Coverage Δ
7.4 ?
8.0 85.42% <ø> (+21.17%) ⬆️
8.1 ?
8.2 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Aws/src/Ecs/Detector.php 92.30% <ø> (ø)
...fony/src/OtelBundle/Resources/services_console.php
...tion/Compiler/SetAliasIfNotDefinedCompilerPass.php
...rc/OtelSdkBundle/Debug/TraceableTracerProvider.php
...Instrumentation/Psr15/src/Psr15Instrumentation.php
src/Context/Swoole/src/SwooleContextDestructor.php
...ymfony/src/OtelSdkBundle/Trace/ExporterFactory.php
src/Symfony/src/OtelBundle/Resources/services.php
...c/OtelBundle/DependencyInjection/Configuration.php
...AsyncClient/src/HttpAsyncClientInstrumentation.php
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf6bd88...a93f772. Read the comment docs.

@pdelewski pdelewski merged commit ee406cd into open-telemetry:main Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants