Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop php 8.0 support #1256

Merged
merged 10 commits into from
Mar 14, 2024
Merged

drop php 8.0 support #1256

merged 10 commits into from
Mar 14, 2024

Conversation

brettmc
Copy link
Collaborator

@brettmc brettmc commented Mar 13, 2024 •
edited
Loading

these are mostly automated changes from rector, applying 8.1 syntax updates.
also, apply some manual type-hint updates and readonly properties that rector missed.

after this is merged, we can separate create PRs to:

  • upgrade phpunit to v10
  • replace some interfaces/classes with enums

@codecov Codecov
Copy link

codecov bot commented Mar 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.00000% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 84.58%. Comparing base (01c46a2) to head (b790767).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1256      +/-   ##
============================================
- Coverage     84.61%   84.58%   -0.03%     
+ Complexity     2137     2136       -1     
============================================
  Files           284      284              
  Lines          6056     6054       -2     
============================================
- Hits           5124     5121       -3     
- Misses          932      933       +1
Flag Coverage Δ
8.0 ?
8.1 84.58% <80.00%> (-0.01%) ⬇️
8.2 84.58% <80.00%> (-0.01%) ⬇️
8.3 84.58% <80.00%> (-0.01%) ⬇️
8.4 84.58% <80.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/API/Baggage/Baggage.php 82.14% <100.00%> (ø)
src/API/Baggage/Entry.php 0.00% <ø> (ø)
src/API/Baggage/Propagation/BaggagePropagator.php 96.87% <100.00%> (ø)
src/API/Baggage/Propagation/Parser.php 100.00% <ø> (ø)
src/API/Globals.php 93.54% <ø> (ø)
src/API/Instrumentation/CachedInstrumentation.php 100.00% <ø> (ø)
src/API/Logs/EventLogger.php 100.00% <ø> (ø)
src/API/Trace/NonRecordingSpan.php 100.00% <100.00%> (ø)
src/API/Trace/NoopSpanBuilder.php 100.00% <100.00%> (ø)
src/API/Trace/SpanContext.php 92.85% <ø> (ø)
... and 126 more

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01c46a2...b790767. Read the comment docs.

@brettmc brettmc marked this pull request as ready for review March 13, 2024 04:42
@brettmc brettmc requested a review from a team March 13, 2024 04:42
agoallikmaa
agoallikmaa approved these changes Mar 14, 2024
View reviewed changes
Copy link

@agoallikmaa agoallikmaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be able to drop symfony/polyfill-php81 dependency.

@Nevay Nevay mentioned this pull request Mar 14, 2024
Merged
@brettmc brettmc merged commit 4cb0499 into open-telemetry:main Mar 14, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nevay Nevay Nevay left review comments

@bobstrecansky bobstrecansky bobstrecansky approved these changes

@agoallikmaa agoallikmaa agoallikmaa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brettmc @agoallikmaa @bobstrecansky @Nevay