Move autoconfigure exporter tests #5051
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 91.17% // Head: 91.17% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #5051 +/- ##
=========================================
Coverage 91.17% 91.17%
Complexity 4871 4871
=========================================
Files 553 553
Lines 14396 14396
Branches 1374 1374
=========================================
+ Hits 13125 13126 +1
Misses 883 883
+ Partials 388 387 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jkwatson
approved these changes
Dec 21, 2022
mateuszrzeszutek
approved these changes
Dec 21, 2022
dmarkwat
pushed a commit
to dmarkwat/opentelemetry-java
that referenced
this pull request
Dec 30, 2022
* Move SPI logging-otlp tests to :exporters:logging-otlp * Move SPI zipkin tests to :exporters:zipkin * Move SPI jaeger tests to :exporters:jaeger * Spotless
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4949.
Moves test code for jaeger, zipkin, and logging-otlp from
:sdk-extensions:autoconfigureto the respective exporter modules. Note that the exporter modules already have integration style tests which don't need to be duplicated. Testing the providers only requires verifying that they properly interpretConfigPropertiesand apply the options when building the exporter. This leads to reduced complexity, which will be especially apparent when moving the OTLP autoconfigure tests in a future PR (we might even see the build time improved since the OTLP autoconfigure tests are fairly slow).