Add default getters to ConfigProperties #4500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breedx-splk
requested review from
anuraaga,
jack-berg,
jkwatson and
jsuereth
as code owners
Codecov Report
@@ Coverage Diff @@
## main #4500 +/- ##
============================================
- Coverage 90.06% 90.05% -0.02%
- Complexity 5040 5051 +11
============================================
Files 578 580 +2
Lines 15553 15558 +5
Branches 1498 1493 -5
============================================
+ Hits 14008 14010 +2
- Misses 1083 1087 +4
+ Partials 462 461 -1
Continue to review full report at Codecov.
|
trask
reviewed
May 27, 2022
...autoconfigure-spi/src/main/java/io/opentelemetry/sdk/autoconfigure/spi/ConfigProperties.java
Outdated
Show resolved
Hide resolved
anuraaga
reviewed
May 29, 2022
...autoconfigure-spi/src/main/java/io/opentelemetry/sdk/autoconfigure/spi/ConfigProperties.java
Outdated
Show resolved
Hide resolved
...autoconfigure-spi/src/main/java/io/opentelemetry/sdk/autoconfigure/spi/ConfigProperties.java
Outdated
Show resolved
Hide resolved
...xtensions/autoconfigure/src/main/java/io/opentelemetry/sdk/autoconfigure/OtlpConfigUtil.java
Outdated
Show resolved
Hide resolved
.../autoconfigure/src/main/java/io/opentelemetry/sdk/autoconfigure/PropagatorConfiguration.java
Outdated
Show resolved
Hide resolved
...oconfigure/src/main/java/io/opentelemetry/sdk/autoconfigure/TracerProviderConfiguration.java
Outdated
Show resolved
Hide resolved
...oconfigure/src/main/java/io/opentelemetry/sdk/autoconfigure/TracerProviderConfiguration.java
Outdated
Show resolved
Hide resolved
anuraaga
approved these changes
Jun 1, 2022
...xtensions/autoconfigure/src/main/java/io/opentelemetry/sdk/autoconfigure/OtlpConfigUtil.java
Outdated
Show resolved
Hide resolved
...toconfigure-spi/src/main/java/io/opentelemetry/sdk/autoconfigure/spi/NullDefaultUtility.java
Outdated
Show resolved
Hide resolved
anuraaga
reviewed
Jun 1, 2022
...ons/autoconfigure/src/test/java/io/opentelemetry/sdk/autoconfigure/ConfigPropertiesTest.java
Outdated
Show resolved
Hide resolved
...ons/autoconfigure/src/test/java/io/opentelemetry/sdk/autoconfigure/ConfigPropertiesTest.java
Outdated
Show resolved
Hide resolved
Merged
anuraaga
reviewed
Jun 2, 2022
...ons/autoconfigure/src/test/java/io/opentelemetry/sdk/autoconfigure/ConfigPropertiesTest.java
Show resolved
Hide resolved
...ons/autoconfigure/src/test/java/io/opentelemetry/sdk/autoconfigure/ConfigPropertiesTest.java
Outdated
Show resolved
Hide resolved
…k/autoconfigure/ConfigPropertiesTest.java Co-authored-by: Anuraag Agrawal <[email protected]>
jack-berg
approved these changes
Jun 2, 2022
jkwatson
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to open-telemetry/opentelemetry-java-instrumentation#4925
This adds several default-capable get* methods to
ConfigProperties. This can help to reduce the number of null checks. These defaults are then wired up in several places.