Skip to content

Deprecate SdkTracerProviderConfigurer #4136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 3, 2022
Merged

Deprecate SdkTracerProviderConfigurer #4136

merged 2 commits into from
Feb 3, 2022

Conversation

jack-berg
Copy link
Member

SdkTracerProviderConfigurer has been superseded by AutoConfigurationCustomizer#addTracerProviderCustomizer(BiFunction).

@jack-berg jack-berg requested a review from a user February 1, 2022 00:10
@jack-berg jack-berg requested a review from Oberon00 as a code owner February 1, 2022 00:10
@codecov
Copy link

codecov bot commented Feb 1, 2022 •
edited
Loading

Codecov Report

Merging #4136 (225b575) into main (586ac11) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #4136      +/-   ##
============================================
+ Coverage     90.20%   90.26%   +0.05%     
- Complexity     4514     4517       +3     
============================================
  Files           533      533              
  Lines         13831    13832       +1     
  Branches       1321     1321              
============================================
+ Hits          12476    12485       +9     
+ Misses          925      916       -9     
- Partials        430      431       +1
Impacted Files Coverage Δ
...nfigure/AutoConfiguredOpenTelemetrySdkBuilder.java 89.52% <100.00%> (ø)
...elemetry/sdk/trace/export/SimpleSpanProcessor.java 83.33% <0.00%> (-4.77%) ⬇️
...telemetry/sdk/trace/export/BatchSpanProcessor.java 90.20% <0.00%> (-0.70%) ⬇️
...autoconfigure/LogEmitterProviderConfiguration.java 100.00% <0.00%> (ø)
...entelemetry/sdk/logs/export/BatchLogProcessor.java 88.05% <0.00%> (+1.49%) ⬆️
...ension/trace/jaeger/sampler/OkHttpGrpcService.java 81.48% <0.00%> (+6.17%) ⬆️
...etry/sdk/logs/export/BatchLogProcessorBuilder.java 84.84% <0.00%> (+9.09%) ⬆️
...y/exporter/otlp/http/logs/OtlpHttpLogExporter.java 77.77% <0.00%> (+11.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 586ac11...225b575. Read the comment docs.

@jkwatson
Update sdk-extensions/autoconfigure/src/testFullConfig/java/io/opente…
225b575 
…lemetry/sdk/autoconfigure/TestTracerProviderConfigurer.java
@anuraaga anuraaga merged commit bd29e1f into open-telemetry:main Feb 3, 2022
@jack-berg jack-berg mentioned this pull request Feb 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuraaga anuraaga anuraaga approved these changes

@jkwatson jkwatson jkwatson approved these changes

@carlosalberto carlosalberto Awaiting requested review from carlosalberto

@jsuereth jsuereth Awaiting requested review from jsuereth

@Oberon00 Oberon00 Awaiting requested review from Oberon00

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jack-berg @anuraaga @jkwatson