[chore]: use ErrorContains and EqualError #35483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
connector/count
connector/sum
exporter/clickhouse
exporter/kafka
exporter/loki
github-actions
bot
added
receiver/solace
receiver/statsd
mmorel-35
force-pushed
the
testify/error-contains
branch
from
04d17ea to
5fa3cc5
Compare
Signed-off-by: Matthieu MOREL <[email protected]>
mmorel-35
force-pushed
the
testify/error-contains
branch
from
5fa3cc5 to
e14eb45
Compare
mmorel-35
requested review from
atoulme,
a team,
jmacd,
dmitryax,
djaglowski,
dashpole,
MovieStoreGuy,
andrzej-stencel,
crobert-1,
TylerHelmuth,
bogdandrutu,
evan-bradley and
jpkrohling
as code owners
atoulme
approved these changes
Sep 30, 2024
songy23
approved these changes
Sep 30, 2024
crobert-1
approved these changes
Sep 30, 2024
crobert-1
added
the
ready to merge
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
#### Description Testifylint doesn't support it yet. This replaces `Contains(t, err.Error()` by `ErrorContains(t, err` and `Equal(t, err.Error()` by `EqualError(t, err` As they both check for nil error it becomes useless to check it yourself without having defined a custom message <!-- Signed-off-by: Matthieu MOREL <[email protected]> --> Signed-off-by: Matthieu MOREL <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testifylint doesn't support it yet.
This replaces
Contains(t, err.Error()byErrorContains(t, errandEqual(t, err.Error()byEqualError(t, errAs they both check for nil error it becomes useless to check it yourself without having defined a custom message