Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore]: enable whitespace linter #11579

Merged
merged 1 commit into from
Oct 31, 2024
Merged

[chore]: enable whitespace linter #11579

merged 1 commit into from
Oct 31, 2024

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Oct 30, 2024 •
edited
Loading

Description

whitespace is a linter that checks for unnecessary newlines at the start and end of functions.

@mmorel-35 mmorel-35 requested a review from a team as a code owner October 30, 2024 23:22
@mmorel-35 mmorel-35 requested a review from bogdandrutu October 30, 2024 23:22
@codecov Codecov
Copy link

codecov bot commented Oct 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.51%. Comparing base (b76b9f7) to head (6072bbf).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11579      +/-   ##
==========================================
- Coverage   91.51%   91.51%   -0.01%     
==========================================
  Files         441      441              
  Lines       23951    23941      -10     
==========================================
- Hits        21919    21909      -10     
  Misses       1653     1653              
  Partials      379      379

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@songy23 songy23 added the ci-cd CI, CD, testing, build issues label Oct 31, 2024
@bogdandrutu bogdandrutu merged commit 0204d95 into open-telemetry:main Oct 31, 2024
66 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 31, 2024
@mmorel-35 mmorel-35 deleted the golangci-lint/whitespace branch October 31, 2024 21:16
djaglowski pushed a commit to djaglowski/opentelemetry-collector that referenced this pull request Nov 21, 2024
@mmorel-35 @djaglowski
[chore]: enable whitespace linter (open-telemetry#11579)
23350c5 
#### Description

[whitespace](https://golangci-lint.run/usage/linters/#whitespace) is a
linter that checks for unnecessary newlines at the start and end of
functions.

Signed-off-by: Matthieu MOREL <[email protected]>
HongChenTW pushed a commit to HongChenTW/opentelemetry-collector that referenced this pull request Dec 19, 2024
@mmorel-35 @HongChenTW
[chore]: enable whitespace linter (open-telemetry#11579)
67cc10b 
#### Description

[whitespace](https://golangci-lint.run/usage/linters/#whitespace) is a
linter that checks for unnecessary newlines at the start and end of
functions.

Signed-off-by: Matthieu MOREL <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@songy23 songy23 songy23 approved these changes

@bogdandrutu bogdandrutu bogdandrutu approved these changes

Assignees
No one assigned
Labels
ci-cd CI, CD, testing, build issues
Projects
None yet
Milestone
v0.113.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mmorel-35 @bogdandrutu @songy23