[internal/sharedcomponent] extract sharedcomponent into another package #11542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VihasMakwana
force-pushed
the
sharedcomponent-module
branch
from
f7fde88 to
a1cb706
Compare
VihasMakwana
force-pushed
the
sharedcomponent-module
branch
from
a1cb706 to
12f0dd7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11542 +/- ##
=======================================
Coverage 91.45% 91.45%
=======================================
Files 438 438
Lines 23827 23827
=======================================
Hits 21791 21791
Misses 1658 1658
Partials 378 378 ☔ View full report in Codecov by Sentry. |
|
Needs a rebase |
|
@bogdandrutu looks good now. Please take a look as |
bogdandrutu
approved these changes
Oct 28, 2024
djaglowski
pushed a commit
to djaglowski/opentelemetry-collector
that referenced
this pull request
Nov 21, 2024
…ge (open-telemetry#11542) Resolves open-telemetry#11442 Also updates `genpdata` command, as the root module doesn't depend on `go.opentelemetry.io/collector/pdata` anymore.
HongChenTW
pushed a commit
to HongChenTW/opentelemetry-collector
that referenced
this pull request
Dec 19, 2024
…ge (open-telemetry#11542) Resolves open-telemetry#11442 Also updates `genpdata` command, as the root module doesn't depend on `go.opentelemetry.io/collector/pdata` anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #11442
Also updates
genpdatacommand, as the root module doesn't depend ongo.opentelemetry.io/collector/pdataanymore.