-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 3d pose inference and visualization #653
Conversation
* Add apis/inference_3d for 3d pose inference * Add 3d keypoint visualization in core/visualization * Move 2d keypoint visualization into core/visualization * Add pose lifter demo
Codecov Report
@@ Coverage Diff @@
## master #653 +/- ##
==========================================
+ Coverage 82.52% 82.83% +0.31%
==========================================
Files 167 169 +2
Lines 11986 12272 +286
Branches 1927 1985 +58
==========================================
+ Hits 9891 10166 +275
+ Misses 1618 1600 -18
- Partials 477 506 +29
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
* Correct keypoint order description in body3d_h36m_dataset * Fix color order in 3d keypoint visualization
* Add normalization parameter into simple_3d_baseline configs (to avoid model init depending on data)
* modify imshow_keypoints_3d, remove argument figsize * fix typo
pyplot is generally slow. I don't know if the speed is okayish |
Perhaps visualization speed is not a critical issue? We can update it when we have better substitutes for matplotlib. |
Yeah it does not block merging. Just saying, my biggest impression on pyplot is its slowness haha. |
Unrelated to this pr: I used plotly for 3d drawing once. The speed is nice. https://github.com/plotly/plotly.py |
* add pose_lifter.show_result [WIP] * Add 3d pose inference and visualization interface * Add apis/inference_3d for 3d pose inference * Add 3d keypoint visualization in core/visualization * Move 2d keypoint visualization into core/visualization * Add pose lifter demo * fix isort * fix bug in body3d_h36m_dataset.py * add unittest for inference_3d * * Add markdown file for 3D human pose demo * Correct keypoint order description in body3d_h36m_dataset * Fix color order in 3d keypoint visualization * fix typo * * Add 3d demo into README.md * Add normalization parameter into simple_3d_baseline configs (to avoid model init depending on data) * * add unittest for visualization * modify imshow_keypoints_3d, remove argument figsize * fix typo * * fix unittest * * fix unittest * modify argument naming
* add pose_lifter.show_result [WIP] * Add 3d pose inference and visualization interface * Add apis/inference_3d for 3d pose inference * Add 3d keypoint visualization in core/visualization * Move 2d keypoint visualization into core/visualization * Add pose lifter demo * fix isort * fix bug in body3d_h36m_dataset.py * add unittest for inference_3d * * Add markdown file for 3D human pose demo * Correct keypoint order description in body3d_h36m_dataset * Fix color order in 3d keypoint visualization * fix typo * * Add 3d demo into README.md * Add normalization parameter into simple_3d_baseline configs (to avoid model init depending on data) * * add unittest for visualization * modify imshow_keypoints_3d, remove argument figsize * fix typo * * fix unittest * * fix unittest * modify argument naming
* add pose_lifter.show_result [WIP] * Add 3d pose inference and visualization interface * Add apis/inference_3d for 3d pose inference * Add 3d keypoint visualization in core/visualization * Move 2d keypoint visualization into core/visualization * Add pose lifter demo * fix isort * fix bug in body3d_h36m_dataset.py * add unittest for inference_3d * * Add markdown file for 3D human pose demo * Correct keypoint order description in body3d_h36m_dataset * Fix color order in 3d keypoint visualization * fix typo * * Add 3d demo into README.md * Add normalization parameter into simple_3d_baseline configs (to avoid model init depending on data) * * add unittest for visualization * modify imshow_keypoints_3d, remove argument figsize * fix typo * * fix unittest * * fix unittest * modify argument naming
This PR added 3d pose inference and visualization interface.