Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3d pose inference and visualization #653

Merged
merged 12 commits into from
May 24, 2021
Merged

Conversation

ly015
Copy link
Member

@ly015 ly015 commented May 18, 2021

This PR added 3d pose inference and visualization interface.

  • Add apis/inference_3d.py
  • Place 2d/3d keypoint visualization into core/visualization/image.py
  • Add show_result method for PoseLifter
  • Simplify show_result method of TopDown and BottomUp
  • Add a demo for 2d-to-3d pose lifting

ly015 added 2 commits May 19, 2021 04:54
* Add apis/inference_3d for 3d pose inference
* Add 3d keypoint visualization in core/visualization
* Move 2d keypoint visualization into core/visualization
* Add pose lifter demo
@ly015 ly015 added the status/WIP work in progress label May 18, 2021
@ly015 ly015 requested review from innerlee and jin-s13 May 18, 2021 21:43
@codecov
Copy link

codecov bot commented May 18, 2021

Codecov Report

Merging #653 (e24c08b) into master (e1ec589) will increase coverage by 0.31%.
The diff coverage is 83.24%.

❗ Current head e24c08b differs from pull request most recent head f2af2d8. Consider uploading reports for the commit f2af2d8 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #653      +/-   ##
==========================================
+ Coverage   82.52%   82.83%   +0.31%     
==========================================
  Files         167      169       +2     
  Lines       11986    12272     +286     
  Branches     1927     1985      +58     
==========================================
+ Hits         9891    10166     +275     
+ Misses       1618     1600      -18     
- Partials      477      506      +29     
Flag Coverage Δ
unittests 82.83% <83.24%> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmpose/apis/inference.py 59.60% <ø> (ø)
mmpose/core/evaluation/__init__.py 100.00% <ø> (ø)
...se/datasets/datasets/body3d/body3d_h36m_dataset.py 82.83% <60.00%> (-2.09%) ⬇️
mmpose/models/detectors/pose_lifter.py 70.37% <62.85%> (-2.97%) ⬇️
mmpose/models/detectors/interhand_3d.py 66.66% <66.66%> (ø)
mmpose/datasets/pipelines/top_down_transform.py 62.35% <75.00%> (-0.08%) ⬇️
mmpose/models/keypoint_heads/interhand_3d_head.py 81.45% <81.45%> (ø)
mmpose/apis/inference_3d.py 85.88% <85.88%> (ø)
mmpose/core/visualization/image.py 92.15% <92.15%> (ø)
mmpose/core/evaluation/top_down_eval.py 64.34% <92.59%> (+3.75%) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1a9474...f2af2d8. Read the comment docs.

ly015 added 2 commits May 19, 2021 11:40
* Correct keypoint order description in body3d_h36m_dataset
* Fix color order in 3d keypoint visualization
@ly015 ly015 removed the status/WIP work in progress label May 19, 2021
ly015 added 2 commits May 19, 2021 21:44
* Add normalization parameter into simple_3d_baseline configs (to avoid model init depending on data)
@jin-s13 jin-s13 mentioned this pull request May 24, 2021
@innerlee
Copy link
Contributor

pyplot is generally slow. I don't know if the speed is okayish

@ly015
Copy link
Member Author

ly015 commented May 24, 2021

Perhaps visualization speed is not a critical issue? We can update it when we have better substitutes for matplotlib.

@innerlee
Copy link
Contributor

Yeah it does not block merging. Just saying, my biggest impression on pyplot is its slowness haha.

@innerlee
Copy link
Contributor

Unrelated to this pr: I used plotly for 3d drawing once. The speed is nice. https://github.com/plotly/plotly.py

@ly015 ly015 merged commit b3999e7 into open-mmlab:master May 24, 2021
@ly015 ly015 deleted the 3d_inference branch July 5, 2021 02:51
minoki pushed a commit to minoki/mmpose that referenced this pull request Jul 13, 2021
* add pose_lifter.show_result [WIP]

* Add 3d pose inference and visualization interface

* Add apis/inference_3d for 3d pose inference
* Add 3d keypoint visualization in core/visualization
* Move 2d keypoint visualization into core/visualization
* Add pose lifter demo

* fix isort

* fix bug in body3d_h36m_dataset.py

* add unittest for inference_3d

* * Add markdown file for 3D human pose demo
* Correct keypoint order description in body3d_h36m_dataset
* Fix color order in 3d keypoint visualization

* fix typo

* * Add 3d demo into README.md
* Add normalization parameter into simple_3d_baseline configs (to avoid model init depending on data)

* * add unittest for visualization
* modify imshow_keypoints_3d, remove argument figsize
* fix typo

* * fix unittest

* * fix unittest

* modify argument naming
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
* add pose_lifter.show_result [WIP]

* Add 3d pose inference and visualization interface

* Add apis/inference_3d for 3d pose inference
* Add 3d keypoint visualization in core/visualization
* Move 2d keypoint visualization into core/visualization
* Add pose lifter demo

* fix isort

* fix bug in body3d_h36m_dataset.py

* add unittest for inference_3d

* * Add markdown file for 3D human pose demo
* Correct keypoint order description in body3d_h36m_dataset
* Fix color order in 3d keypoint visualization

* fix typo

* * Add 3d demo into README.md
* Add normalization parameter into simple_3d_baseline configs (to avoid model init depending on data)

* * add unittest for visualization
* modify imshow_keypoints_3d, remove argument figsize
* fix typo

* * fix unittest

* * fix unittest

* modify argument naming
HAOCHENYE pushed a commit to HAOCHENYE/mmpose that referenced this pull request Jun 27, 2023
ajgrafton pushed a commit to ajgrafton/mmpose that referenced this pull request Mar 6, 2024
* add pose_lifter.show_result [WIP]

* Add 3d pose inference and visualization interface

* Add apis/inference_3d for 3d pose inference
* Add 3d keypoint visualization in core/visualization
* Move 2d keypoint visualization into core/visualization
* Add pose lifter demo

* fix isort

* fix bug in body3d_h36m_dataset.py

* add unittest for inference_3d

* * Add markdown file for 3D human pose demo
* Correct keypoint order description in body3d_h36m_dataset
* Fix color order in 3d keypoint visualization

* fix typo

* * Add 3d demo into README.md
* Add normalization parameter into simple_3d_baseline configs (to avoid model init depending on data)

* * add unittest for visualization
* modify imshow_keypoints_3d, remove argument figsize
* fix typo

* * fix unittest

* * fix unittest

* modify argument naming
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants