Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #564 : Add a common helloMMS Converge Dockerfile for all ARCH #574

Merged
merged 1 commit into from
Jan 22, 2023
Merged

Issue #564 : Add a common helloMMS Converge Dockerfile for all ARCH #574

merged 1 commit into from
Jan 22, 2023

Conversation

dipesh-rawat
Copy link
Contributor

This PR fixes #564

The following changes were made in this PR:

  • Delete the multiple Dockerfile.arch files
  • Add a common Dockerfile that will be used for building all arch containers
  • Modify the Makefile to build using docker build --platform linux/$(ARCH)

@dipesh-rawat dipesh-rawat mentioned this pull request Jan 22, 2023
Closed
@johnwalicki johnwalicki marked this pull request as ready for review January 22, 2023 18:20
johnwalicki
johnwalicki approved these changes Jan 22, 2023
View reviewed changes
Copy link
Member

@johnwalicki johnwalicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnwalicki johnwalicki merged commit 5b21fb8 into open-horizon:master Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnwalicki johnwalicki johnwalicki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: helloMMS Converge on one Dockerfile
2 participants
@dipesh-rawat @johnwalicki