Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #572 - Move SDR documentation to SDR repo #573

Merged
merged 4 commits into from
Jan 17, 2023
Merged

Issue #572 - Move SDR documentation to SDR repo #573

merged 4 commits into from
Jan 17, 2023

Conversation

johnwalicki
Copy link
Member

Signed-off-by: John Walicki [email protected]

This PR fixes #572

Add the SDR doc and diagram to the example SDR directory as first step of sunsetting the SDR docs from the Open Horizon Documentation website.

@t-fine
Copy link
Collaborator

t-fine commented Jan 4, 2023

@johnwalicki hm, do you think these files would fit better in the edge/evtstreams/sdr2evtstreams directory? That is more of the "top level application" of the SDR service. Or maybe a few key files could just be duplicated?

@johnwalicki
Copy link
Member Author

@t-fine Possibly, I don't have an opinion. I've never implemented this service. My goal was to preserve the documentation / image files and kill off the OH SDR docs.

Where do you recommend?

@t-fine
Copy link
Collaborator

t-fine commented Jan 5, 2023

@johnwalicki alright yeah then if you don't mind moving them over to edge/evtstreams/sdr2evtstreams that would be awesome

@johnwalicki
Copy link
Member Author

@t-fine I've pushed another commit into this PR which moves the SDR architecture diagrams to the edge/evtstreams/sdrevtstreams directory.

Please review / approve if appropriate.

@johnwalicki
Issue #572 - Add SDR Arch diagram
7015c00 
Signed-off-by: John Walicki <[email protected]>
@t-fine
Copy link
Collaborator

t-fine commented Jan 17, 2023

@johnwalicki this looks good to me! I'll go ahead and merge. Sorry for the delay

@t-fine t-fine merged commit 2f85acd into master Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-fine t-fine t-fine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation📄: Move the SDR docs into the SDR directory
2 participants
@johnwalicki @t-fine