Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting issue in Google provider doc #2907

Merged
merged 4 commits into from
Jan 9, 2025

Conversation

jrnewton
Copy link
Contributor

@jrnewton jrnewton commented Jan 8, 2025

Description

A missing line break caused subsequent list items to be squished into a single paragraph.

Motivation and Context

Instructions are hard to follow when the items are not displayed in a proper list.

How Has This Been Tested?

It's a doc change, made sure doc looked correct in markdown preview.

Checklist:

  • My change requires a change to the documentation or CHANGELOG.
  • I have updated the documentation/CHANGELOG accordingly.
  • I have created a feature (non-master) branch for my PR.
  • I have written tests for my code changes.

@jrnewton jrnewton requested a review from a team as a code owner January 8, 2025 13:17
@github-actions github-actions bot added the docs label Jan 8, 2025
Copy link
Member

@tuunit tuunit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing :)

Can you please apply the same change to:

docs/versioned_docs/version-7.6.x/configuration/providers/google.md

docs/docs/configuration/providers/google.md

@jrnewton
Copy link
Contributor Author

jrnewton commented Jan 8, 2025

Apologies - that commit has tons of whitespace changes. Will redo.

A missing line break caused subsequent list items to be squished into a single paragraph.
A missing line break caused subsequent list items to be squished into a single paragraph.
A missing line break caused subsequent list items to be squished into a single paragraph.
@tuunit tuunit merged commit 60570cc into oauth2-proxy:master Jan 9, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants