Change redirect code from 302 to 307 #2905
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting this will most definitely be a breaking change for some people :/ |
|
Yes, but if documented correctly and deployed in a major version we could avoid major disruptions/issues. And I strongly believe that fixing this issue would help quite some people being stuck with this very unexpected behavior of oauth2 breaking non GET requests. Any chance to integrate this feature to the future v8 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
oauth-proxy should return 307 redirect code to prevent the original request method loss by browsers.
Motivation and Context
Fixes #2903
How Has This Been Tested?
Tested locally with the provided
docker-composein contrib and keycloak environment.Checklist: