-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Entra ID: Workload Identity support #2902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+169
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuunit
requested changes
Jan 8, 2025
c57fe70 to
5c036ee
Compare
tuunit
approved these changes
Jan 11, 2025
Member
tuunit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
g-linville
pushed a commit
to obot-platform/oauth2-proxy
that referenced
this pull request
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds additional flag to Entra ID provider -
entra_id_federated_token_auth_enabled. When enabled, oAuth2 proxy exchanges code for tokens by using federated token projected in the well known place by Entra Workload Identity plugin.This change introduces a custom implementation of
Redeem(). When federated auth is enabled, tokens are retrieved by custom query (with different parameters), and passed to genericp.OIDCProvider.createSession().Motivation and Context
Workload Identity in Entra allows to stop using hardcoded client secret which is a huge benefit for IaaC, reference architectures and secret management.
How Has This Been Tested?
E2E testing for Entra provider has been extended to perform same 15 cases that are performed with client-secret configuration. Test are passing properly.
Checklist: