Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow use more possible google admin-sdk api scopes. #2743

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

BobDu
Copy link

@BobDu BobDu commented Aug 16, 2024

According to Google's requirements, as long as one of the API scopes is present, the hasMember method can be allow.

https://developers.google.com/admin-sdk/directory/reference/rest/v1/members/hasMember#authorization-scopes

https://apps-apis.google.com/a/feeds/groups/
https://www.googleapis.com/auth/admin.directory.group
https://www.googleapis.com/auth/admin.directory.group.member
https://www.googleapis.com/auth/admin.directory.group.member.readonly
https://www.googleapis.com/auth/admin.directory.group.readonly

Additionally, update the documentation to recommend setting the minimum required permissions scope.

Description

Motivation and Context

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation or CHANGELOG.
  • I have updated the documentation/CHANGELOG accordingly.
  • I have created a feature (non-master) branch for my PR.
  • I have written tests for my code changes.

@BobDu BobDu requested a review from a team as a code owner August 16, 2024 12:24
Copy link
Contributor

This pull request has been inactive for 60 days. If the pull request is still relevant please comment to re-activate the pull request. If no action is taken within 7 days, the pull request will be marked closed.

@github-actions github-actions bot added the Stale label Oct 16, 2024
@BobDu
Copy link
Author

BobDu commented Oct 16, 2024

ping @tuunit @JoelSpeed
Are there any maintainers interested in this PR?

@github-actions github-actions bot removed the Stale label Oct 17, 2024
@BobDu
Copy link
Author

BobDu commented Jan 6, 2025

A friendly ping again
@tuunit @JoelSpeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant