-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Unable to use hyphen in JSON path for oidc-groups-claim option #2619
Conversation
This pull request has been inactive for 60 days. If the pull request is still relevant please comment to re-activate the pull request. If no action is taken within 7 days, the pull request will be marked closed. |
@rd-danny-fleer this removes the possibility to use json path. The code should be fixed by correcting the inverted logic :
And not
Testing for |
Would you be willing to open a PR for this change and add more extensive tests? |
Will do. I'd prefer JMESPath but JSONPATH would be good enough in most cases. |
Description
Motivation and Context
Fix #2618
I know there might be better solutions, like implementing a feature flag and an additional option to control if
oidc-groups-claims
should be evaluated as string or JSON path.However such a change might be breaking and I didn't want to anticipate the decision for an alternative. Therefore I implemented a simple solution in the first step.
How Has This Been Tested?
Added additional tests.
Checklist: