Add scopes claim #2556
Open
Add scopes claim #2556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been inactive for 60 days. If the pull request is still relevant please comment to re-activate the pull request. If no action is taken within 7 days, the pull request will be marked closed. |
|
This pull request has been inactive for 60 days. If the pull request is still relevant please comment to re-activate the pull request. If no action is taken within 7 days, the pull request will be marked closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The "scopes" claim is added
Motivation and Context
I want to provide upstream with X-Forwarded-Scopes header which shall contain the effective scopes granted by IDM.
Consider kanidm where scopes are collected with respect to user-group membership. The scopes are effectively rights granted to the user and passing them directly will allow to switch some applications to trusted sso headers thus simplifying such applications auth procedures (no need in unpacking cookie/authorization header).
How Has This Been Tested?
I'm new to Go and I just clone the existing code relevant to very similar "groups" claim. It works fine on my setup.
I don't see how it could affect affects other areas of the code in negative way.
If this PR is welcome I would appreciate if someone with stronger level in Go took the code and added needed (if any) tests.
This would allow me to study by example.
TIA
Checklist: