-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh Token on Demand #2431
base: master
Are you sure you want to change the base?
Refresh Token on Demand #2431
Conversation
Is it possible to get this pull request reviewed? We find this feature extremely useful for our use case where we have data set in the JWT that may change overtime. The change allows us to force a refresh request from the IDP thereby allowing the JWT to be updated without forcing the user to reauthenticate. |
I agree with @cmbaatz, this will solve several use cases for more than one project 🚀 |
PR Is up to date after @cmbaatz merge. :) |
@JoelSpeed , @NickMeves, @tuunit , or @kvanzuijlen this my second attempt to contribute this code to the project and both times it appears that the PR is left to expire. At it's base all this code change does is expose the OIDC/Oauth2 refresh endpoint. How or why that's used by users is entirely up to their own needs from the proxy. How can I help move this PR forward? |
@JoelSpeed, @NickMeves, @tuunit @kvanzuijlen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we need to be adding some sort of rate limiting, or minimum refresh period to avoid users spamming this endpoint and causing issues, WDYT?
I'm really happy that the code review for this PR started :) thanks @JoelSpeed and @cmbaatz :) |
Co-authored-by: Jan Larwig <[email protected]>
This pull request has been inactive for 60 days. If the pull request is still relevant please comment to re-activate the pull request. If no action is taken within 7 days, the pull request will be marked closed. |
Please, don't die. |
This pull request has been inactive for 60 days. If the pull request is still relevant please comment to re-activate the pull request. If no action is taken within 7 days, the pull request will be marked closed. |
Any updates on this? @cmbaatz do you have helm repo that I could use with your changes? Any plans to bump to latest version? |
@tuunit Is there anything remaining on this PR that we can help to get it merged? This functionality would solve a big challenge for us. |
# Conflicts: # docs/docs/features/endpoints.md
@jjmanton So the code is all in place. Last that was asked back in April was for some help cleaning up some of the code in stored_session.go. I didn't have a lot of free time until now, and will try to get around to the work before the end of the year. If you want, I can help you build/deploy my branch onto your system. We have done that for years now and have not had issues. fyi: @tuunit I just updated my branch, if you would like to forgo the cleanup on the legacy code. I know a number of users have been requesting this feature for some time. |
@tuunit / @JoelSpeed |
Description
Adding a refresh endpoint that allows a user to refresh the JWT stored in the session without invalidating the session.
Motivation and Context
Within our application some mutable information is stored as attributes in our IDP (Keycloak). When a detail like a user's role or allowed tenants is updated we would like the ability to force the session store to refresh the JWT from our IDP in order to reflect the new values. We want to perform this operation in a way that is seamless to the user and doesn't require them to re-authenticate as this would be disruptive to their use of the application.
This issue was originally identified in issue #2019
How Has This Been Tested?
Yes,
Checklist: