Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add client assertions auth for oidc base provider #2378

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

[WIP] Add client assertions auth for oidc base provider #2378

wants to merge 6 commits into from

Conversation

tuunit
Copy link
Member

@tuunit tuunit commented Jan 7, 2024

Replaces #2305

Description

Support client_assertion in generic OIDC provider

Motivation and Context

Enterprise oidc often prefers client assertions instead of clientid/clientsecret auth on redeem and refresh
Also: #1834

How Has This Been Tested?

TBD

Checklist:

  • My change requires a change to the documentation or CHANGELOG.
  • I have updated the documentation/CHANGELOG accordingly.
  • I have created a feature (non-master) branch for my PR.
  • I have written tests for my code changes.

@tuunit tuunit requested a review from a team as a code owner January 7, 2024 17:29
@tuunit tuunit changed the title Add client assertions auth for oidc base provider [WIP] Add client assertions auth for oidc base provider Jan 7, 2024
This was referenced Jan 14, 2024
Merged
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024

This pull request has been inactive for 60 days. If the pull request is still relevant please comment to re-activate the pull request. If no action is taken within 7 days, the pull request will be marked closed.

@github-actions github-actions bot added the Stale label Mar 8, 2024
@github-actions github-actions bot closed this Mar 17, 2024
@tuunit tuunit reopened this Mar 25, 2024
@github-actions github-actions bot removed the Stale label Mar 27, 2024
@lorenzo-biava lorenzo-biava mentioned this pull request May 14, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been inactive for 60 days. If the pull request is still relevant please comment to re-activate the pull request. If no action is taken within 7 days, the pull request will be marked closed.

@github-actions github-actions bot added the Stale label May 26, 2024
@cdlliuy
Copy link

cdlliuy commented May 27, 2024

@tuunit , just wonder what is the plan for this PR? Supporting client_assertion is very heplful for azure provider as well

@github-actions github-actions bot removed the Stale label May 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been inactive for 60 days. If the pull request is still relevant please comment to re-activate the pull request. If no action is taken within 7 days, the pull request will be marked closed.

@github-actions github-actions bot added the Stale label Jul 28, 2024
@github-actions github-actions bot closed this Aug 5, 2024
@tuunit tuunit reopened this Aug 5, 2024
@tuunit tuunit removed the Stale label Aug 5, 2024
@meesvandongen
Copy link

@tuunit when you are read to merge this, can you also merge in tuunit#11 ?

@jjlakis jjlakis mentioned this pull request Jan 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
go provider tests
Projects
OAuth2-Proxy Release Planning & Roadmap
Status: Accepted / Queued
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tuunit @cdlliuy @meesvandongen @prevostc