Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ojg to latest release #2357

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Conversation

bitfehler
Copy link
Contributor

The previously used release is no longer available on Github.

Description

When building the current master branch, I get the following error:

pkg/providers/util/claim_extractor.go:14:2: reading github.com/ohler55/ojg/go.mod at revision v1.14.5: unknown revision v1.14.5

And indeed, the latest tag to be found over at ojg is 1.15.0. This is obviously a tad strange, not sure how a tag would disappear, but I leave that judgement up to you. After this patch, oauth2-proxy builds fine for me.

Motivation and Context

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation or CHANGELOG.
  • I have updated the documentation/CHANGELOG accordingly.
  • I have created a feature (non-master) branch for my PR.
  • I have written tests for my code changes.

@bitfehler bitfehler requested a review from a team as a code owner December 19, 2023 14:50
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Dec 19, 2023
Copy link
Member

@tuunit tuunit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bitfehler,

please add an entry for this PR to the CHANGELOG.md

The previously used release is no longer available on Github.
@bitfehler
Copy link
Contributor Author

Done

@bitfehler bitfehler mentioned this pull request Jan 3, 2024
3 tasks
Copy link
Member

@tuunit tuunit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tuunit tuunit added the LGTM PR is ready to merge label Jan 6, 2024
@JoelSpeed JoelSpeed merged commit 71561f6 into oauth2-proxy:master Jan 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog dependencies Pull requests that update a dependency file docs LGTM PR is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants