Introduce refresh token flow without cookie #2124
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would be very helpful feature in case kubectl access with refresh_token where the id_token expiry is 5min. |
|
This pull request has been inactive for 60 days. If the pull request is still relevant please comment to re-activate the pull request. If no action is taken within 7 days, the pull request will be marked closed. |
|
@ferencszatmari could you fix the issue displayed in the codeclimate action? |
|
This pull request has been inactive for 60 days. If the pull request is still relevant please comment to re-activate the pull request. If no action is taken within 7 days, the pull request will be marked closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Contributors,
I would like to ask for your help regarding the pull request below. There is a need for a refresh token flow without using cookies. Since I couldn't find any documentation on this topic, I downloaded the code and implemented it. However, I have no experience with the GO language, and I'm not familiar with your codebase either. Nevertheless, we need this flow, and I would like to ask for your assistance on what is needed to include this feature in the next version.
The flow is as follows:
User logs in through the browser.
We store the following two header values from the response: X-Auth-Request-Access-Token, X-Auth-Request-Refresh-Token.
We call the following endpoint: oauth2/refresh (IMPORTANT: without using any cookies)
The request requires sending the following headers with the stored values:
Authorization: ${X-Auth-Request-Access-Token)
RefreshToken: ${X-Auth-Request-Refresh-Token}
We receive new values for the headers mentioned in step 2 in the response. We need to store them and repeat the refresh process.
I branched off from version 7.4. Thank you in advance for your assistance.