Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix import location of gmock library in install target not being set #18501

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Fix import location of gmock library in install target not being set #18501

merged 1 commit into from
Nov 22, 2024

Conversation

mprettner-huawei
Copy link
Contributor

What does this PR do?

The import location of the gmock library, which is built from source via FetchContent, is not set correctly for the install layout of the engine, leading to the following error:

CMake Error in D:/code/o3de/install/Code/Framework/AzTest/CMakeLists.txt:
  IMPORTED_LOCATION not set for imported target "gmock" configuration
  "Profile".

How was this PR tested?

Build the install target of the engine and check if the aforementioned error is no longer happening.

@mprettner-huawei mprettner-huawei requested a review from a team as a code owner November 22, 2024 12:18
nick-l-o3de
nick-l-o3de approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@nick-l-o3de nick-l-o3de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops!

@nick-l-o3de nick-l-o3de merged commit 05a6061 into o3de:development Nov 22, 2024
3 checks passed
@mprettner-huawei mprettner-huawei mentioned this pull request Dec 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nick-l-o3de nick-l-o3de nick-l-o3de approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mprettner-huawei @nick-l-o3de