Add default-members entry in nym-vpn-core workspace #1773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add default-members to the `nym-vpn-core` workspace since usually people only want to build the main binaries, and not bother with e.g `nym-gateway-probe`. Adding only `nym-vpnd` and `nym-vpnc`, but transitively most crates will be built still.
pronebird
approved these changes
Dec 11, 2024
pronebird
requested changes
Dec 11, 2024
There was a problem hiding this comment.
Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @octol)
a discussion (no related file):
Breaks on iOS:
Run cargo run --bin uniffi-bindgen generate \
cargo run --bin uniffi-bindgen generate \
--library target/aarch64-apple-ios/debug/libnym_vpn_lib.a \
--config crates/nym-vpn-lib/uniffi.toml \
--language swift --out-dir build -n
shell: /bin/bash -e {0}
env:
IPHONEOS_DEPLOYMENT_TARGET: 16
CARGO_TERM_COLOR: always
AGENT_ISSELFHOSTED: 1
error: no bin target named `uniffi-bindgen`.
Available bin targets:
nym-vpnc
nym-vpnd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add default-members to the
nym-vpn-coreworkspace since usually peopleonly want to build the main binaries, and not bother with e.g
nym-gateway-probe.Adding only
nym-vpndandnym-vpnc, but transitively most crates willbe built still.
This change is