Reviewed 37 of 45 files at r1.
Reviewable status: 37 of 45 files reviewed, 4 unresolved discussions (waiting on @doums, @neacsu, @octol, @rokas-ambrazevicius, and @zaneschepke)

nym-vpn-core/crates/nym-mixnet-client/src/lib.rs line 23 at r1 (raw file):

}

impl SharedMixnetClient {

Nit: oh I'd be happy to get rid of this type as it holds Arc<Mutex<>> and does a lot of unwrapping. Personally I'd for channel instead to keep it safe.

nym-vpn-core/crates/nym-mixnet-client/src/lib.rs line 26 at r1 (raw file):

    pub fn new(
        mixnet_client: MixnetClient,
        #[cfg(target_os = "android")] tun_provider: Arc<dyn AndroidTunProvider>,

I think it would be much simpler to pass Fn(RawFd) instead of AndroidTunProvider which should reduce cross-module dependencies.

nym-vpn-core/Cargo.toml line 14 at r1 (raw file):

    "crates/nym-ip-packet-client",
    "crates/nym-mixnet-client",
    "crates/nym-routing", "crates/nym-tunnel-provider",

nit: add newline between crates

nym-vpn-core/crates/nym-vpn-lib/src/tunnel_state_machine/tunnel/mod.rs line 48 at r1 (raw file):

impl ConnectedMixnet {
    /// Returns the websocket fd owned by mixnet client.

Please fix documentation

Reviewable status: 23 of 45 files reviewed, 3 unresolved discussions (waiting on @doums, @octol, @pronebird, @rokas-ambrazevicius, and @zaneschepke)

nym-vpn-core/crates/nym-mixnet-client/src/lib.rs line 26 at r1 (raw file):

Did this in the separated PR, thanks for the idea.

nym-vpn-core/crates/nym-vpn-lib/src/tunnel_state_machine/tunnel/mod.rs line 48 at r1 (raw file):

Done.