Reviewed 1 of 4 files at r1.
Reviewable status: 1 of 4 files reviewed, 1 unresolved discussion (waiting on @doums, @neacsu, @octol, @rokas-ambrazevicius, and @zaneschepke)

nym-vpn-core/crates/nym-vpn-lib/src/tunnel_state_machine/tunnel/mod.rs line 163 at r1 (raw file):

    };

    let mut mixnet_client_config = options.clone().mixnet_client_config.unwrap_or_default();

Nit: Probably better to clone mixnet_client_config instead of all options.

Reviewed 1 of 4 files at r1, 2 of 2 files at r2.
Reviewable status: all files reviewed (commit messages unreviewed), 2 unresolved discussions (waiting on @doums, @neacsu, @octol, @rokas-ambrazevicius, and @zaneschepke)

nym-vpn-core/crates/nym-vpn-lib/src/bandwidth_controller.rs line 20 at r2 (raw file):

};
use nym_wg_gateway_client::{ErrorMessage, GatewayData, WgGatewayClient, WgGatewayLightClient};
use tokio_util::sync::CancellationToken;

Nit I started doing use separation using the following pattern:

use std::...

// external
use tokio::...

// workspace crates
use nym_*::...

// inside of executable/lib
use super::...

Not sure if you like it.

Reviewable status: 2 of 4 files reviewed, 1 unresolved discussion (waiting on @doums, @octol, @pronebird, and @rokas-ambrazevicius)

nym-vpn-core/crates/nym-vpn-lib/src/bandwidth_controller.rs line 20 at r2 (raw file):

I like it, I was trying to do something similar, but not very consistently. Applied it here, will try to apply it more in the future as well

I say if it works, ship it! :)
Possibly we can take a stab at integrating it further into the state machine later, but I'm not really up to date on what's the best approach there