-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
feat(nuxt): enable dragging and minimizing for error overlay #33695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
WalkthroughReworks the Nuxt error overlay UI and runtime utilities to add an edge-based docking system, draggable Pip and Preview, and persistent dock/hidden state via storage sync. Introduces new DOM controls (pip-close, pip-restore), replaces the toggle button with a custom toggle element, and reorders shadow DOM appends to satisfy adjacency rules. Adds CSS custom properties for dock offsets and transform-origin, viewport-clamping and snapping logic, unified repaint on resize/scroll, pointer-event drag handlers, and live preview snapshot update logic. No exported/public function signatures were changed. Estimated code review effort🎯 4 (Complex) | ⏱️ ~45–60 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (1)**/*.{ts,tsx}📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/nitro-server/src/runtime/utils/dev.ts(8 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Follow standard TypeScript conventions and best practices
Files:
packages/nitro-server/src/runtime/utils/dev.ts
@nuxt/kit
@nuxt/nitro-server
nuxt
@nuxt/rspack-builder
@nuxt/schema
@nuxt/vite-builder
@nuxt/webpack-builder
commit: |
CodSpeed Performance ReportMerging #33695 will not alter performanceComparing Summary
|
|
I think:
|
… and update positioning
…y logic and grouped related code
danielroe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you ❤️
🔗 Linked issue
resolves #33659
📚 Description
First Nuxt contribution, fingers crossed!
This PR adds dragging and minimizing to the Error Overlay added in Nuxt 4.2. Dragging snaps around the edges and the PiP window's position is stored via localstorage.
The window can be "closed", which will minimize it into a small pill-shaped non-intrusive button to reopen it. This preference is also stored in localstorage.
I didn't know how to write an actual test for this, but I'm willing to put effort into it with some guidance!
In the meanwhile, testing this is simple: throw an error in the playground
app.vueand try dragging the pip window around!