NXP-30834: allow DocumentModelCSVWriter to write documents from other repositories #5052
+48
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View issue in JIRA: NXP-30834: Fix CSV export of multi-repo Page Provider results |
|
Same fix as in https://jira.nuxeo.com/browse/NXP-30615. |
NourNuxeo
reviewed
Jan 28, 2022
| // do not try to re-attach a detached or non-existing document | ||
| doWriteEntityBody(entity, printer); | ||
| } else { | ||
| withDocumentAttached(entity, () -> doWriteEntityBody(entity, printer)); |
There was a problem hiding this comment.
wouldn't it be better to create the method when we have more uses cases? I feel like this method has been created "in case" we need to make more use of it with yet-to-come different runnables?
ataillefer
previously approved these changes
Feb 1, 2022
ataillefer
force-pushed
the
10.10-HF/fix-NXP-30834-doc-csv-writer-multi-repo
branch
from
8685af2
to
4e0ea88
Compare
|
Rebased on 10.10. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.