NXP-26872: Overall ZIP CSV Improvements to improve functionality and align with CSV import #3914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eikkaj
force-pushed
the
feature-NXP-26872-ZIPCSV-Improvement
branch
from
ef5fbfc
to
c910238
Compare
efge
reviewed
Apr 15, 2020
...-core/src/main/java/org/nuxeo/ecm/platform/filemanager/service/extension/CSVZipImporter.java
Outdated
Show resolved
Hide resolved
eikkaj
force-pushed
the
feature-NXP-26872-ZIPCSV-Improvement
branch
from
c4fb195
to
1c89c5a
Compare
efge
reviewed
May 13, 2020
...-core/src/main/java/org/nuxeo/ecm/platform/filemanager/service/extension/CSVZipImporter.java
Outdated
Show resolved
Hide resolved
...-core/src/main/java/org/nuxeo/ecm/platform/filemanager/service/extension/CSVZipImporter.java
Outdated
Show resolved
Hide resolved
...-core/src/main/java/org/nuxeo/ecm/platform/filemanager/service/extension/CSVZipImporter.java
Outdated
Show resolved
Hide resolved
…align with CSV import -- name field should be required -- id field should not be used -- update should be supported -- tags should be supported -- list type should be supported
eikkaj
force-pushed
the
feature-NXP-26872-ZIPCSV-Improvement
branch
from
872d4e1
to
d4909cc
Compare
efge
approved these changes
May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- name field should be required
-- id field should not be used
-- update should be supported
-- tags should be supported
-- list type should be supported
-- combined archive files per request of nuxeo