Bump tabled to 0.17 #14415
Merged
Bump tabled to 0.17 #14415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this comes a new unicode-width. And a bit of refactorings Signed-off-by: Maxim Zhiburt <[email protected]>
Contributor
|
Glad to see that you got some help from josh triplett to update tabled. Anxious to see this go green so we can use the latest version. |
Contributor
Author
|
Allthough CI is green, I still hold a desire to work a little bit more on refactoring. |
Contributor
|
@zhiburt no worries. Just ping me when you're ready for review. |
Contributor
|
How's this PR coming? |
Contributor
Author
|
It always surprises how time is flies..... I'd say there's quite a room for improvement still and I'd love to get it finished, So yes a little more time please 😄 If I won't be finished by this week, PS: Maybe it was a mistake to do unrelated refactorings with a version update in the same PR to begin with 😅 |
Contributor
|
No worries. My ping was just a gentle reminder and hoping you were still able to work on it. Sounds like you are. We appreciate all your help. |
Contributor
Author
|
Well I haven't managed to reduce the lines 😅 but IMHO reduced boiler plate quite a bit. I think it's good to go. Self Notes - work could be done:
|
Contributor
|
Thanks @zhiburt for all your work on this. I think it's too close to our release to land it now but I'll tag it for later. |
fdncred
added
A:table-renderer
Contributor
|
when you have time, can you fix the conflicts? |
Contributor
Author
|
Seems like done; though as I said I'd run it just in case 😄 |
Contributor
|
Seems to be working. Let's give it a try and see if we can break it. |
Contributor
|
@zhiburt I'm experiencing weird problems this morning with nushell. I git bisected it down to this PR. If I type In a debug version, it panics. Here's a full backtrace copied to a new issue #14701 |
Contributor
Author
|
😞 |
fdncred
pushed a commit
that referenced
this pull request
Jan 11, 2025
<!-- if this PR closes one or more issues, you can automatically link the PR with them by using one of the [*linking keywords*](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword), e.g. - this PR should close #xxxx - fixes #xxxx you can also mention related issues, PRs or discussions! --> # Description <!-- Thank you for improving Nushell. Please, check our [contributing guide](../CONTRIBUTING.md) and talk to the core team before making major changes. Description of your pull request goes here. **Provide examples and/or screenshots** if your changes affect the user experience. --> This PR removes the `std::io::stdout().is_terminal()` check in `table` again. To ensure that in the future this doesn't happen again, I added a comment and a test. # User-Facing Changes <!-- List of all changes that impact the user experience here. This helps us keep track of breaking changes. --> Resets the behavior of `table` to #14647 again, after #14415 included it again. # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass (on Windows make sure to [enable developer mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging)) - `cargo run -- -c "use toolkit.nu; toolkit test stdlib"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> Added a new test to check for these color outputs. - 🟢 `toolkit fmt` - 🟢 `toolkit clippy` - 🟢 `toolkit test` - 🟢 `toolkit test stdlib` # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this comes a new
unicode-widthas I remember there was some issue withratatui.And a bit of refactorings which are ment to reduce code lines while not breaking anything.
Not yet complete, I think I'll try to improve some more places,
just wanted to trigger CI 😄
And yessssssssss we have a new
unicode-widthbut I sort of doubtful,I mean the original issue with emojie.
I think it may require an additional "clean" call.
I am just saying I was not testing it with that case of complex emojies.