Implement chunk_by operation #14410
Merged
Implement chunk_by operation #14410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi, thank you for the contribution! |
Contributor
|
I think this is a good addition but I think the Rust name (would be Plus we already have the |
IanManske
reviewed
Nov 26, 2024
Member
IanManske
left a comment
IanManske
left a comment
There was a problem hiding this comment.
Thanks for the PR! Just some notes:
The type specification is more detailed, and now allows for range inputs
cosineblast
changed the title
IanManske
reviewed
Nov 29, 2024
Member
IanManske
left a comment
IanManske
left a comment
There was a problem hiding this comment.
Thanks for the PR and all the fixes! Merging 🚀
fdncred
added
deprecated:pr-commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull requests implements a new
partition-bychunk-bycommand. The operation takes a closure and partitions the input list into sublists based on the return value of the closure.group-byoperation #14149Examples, tests and and documentation were added accordingly.