Skip to content

deprecate --ignore-shell-errors and --ignore-program-errors in do #14385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 27, 2024
Merged

deprecate --ignore-shell-errors and --ignore-program-errors in do #14385

merged 4 commits into from
Nov 27, 2024

Conversation

WindSoilder
Copy link
Contributor

Description

As title, this pr is going to deprecate --ignore-shell-errors and --ignore-program-errors.

Because I think these two flags makes do command complicate, and it should be easy to use -i instead.

User-Facing Changes

After the pr, using these two flags will raise deprecated warning.

> do --ignore-program-errors { ^pwd }
Error:   × Deprecated option
   ╭─[entry #2:1:1]
 1 │ do --ignore-program-errors { ^pwd }
   · ─┬
   ·  ╰── `--ignore-program-errors` is deprecated and will be removed in 0.102.0.
   ╰────
  help: Please use the `--ignore-errors(-i)`
/home/windsoilder/projects/nushell
> do --ignore-shell-errors { ^pwd }
Error:   × Deprecated option
   ╭─[entry #3:1:1]
 1 │ do --ignore-shell-errors { ^pwd }
   · ─┬
   ·  ╰── `--ignore-shell-errors` is deprecated and will be removed in 0.102.0.
   ╰────
  help: Please use the `--ignore-errors(-i)`
/home/windsoilder/projects/nushell

Tests + Formatting

NaN

@WindSoilder WindSoilder added the deprecation Related to the deprecation of commands/features/options label Nov 19, 2024
@fdncred fdncred mentioned this pull request Nov 19, 2024
Closed
@WindSoilder WindSoilder merged commit e0c0d39 into nushell:main Nov 27, 2024
13 checks passed
@github-actions github-actions bot added this to the v0.101.0 milestone Nov 27, 2024
@blended-bram
Copy link

Seems I missed the update in between and when brew upgraded to 104 my shell broke because --ignore-shell-errors was part of the (default) create_left_prompt function that was in the env config.

The result was that the shell got so broken that it couldn't even find itself anymore, as PATH got very broken as well.

@blended-bram blended-bram mentioned this pull request May 6, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@132ikl 132ikl 132ikl left review comments

@sgvictorino sgvictorino sgvictorino left review comments

Assignees
No one assigned
Labels
deprecation Related to the deprecation of commands/features/options
Projects
None yet
Milestone
v0.101.0
Development

Successfully merging this pull request may close these issues.
4 participants
@WindSoilder @blended-bram @132ikl @sgvictorino