enable test_cp_recurse on macos #14358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I'm not sure why these tests were disabled on macos originally. @dmatos2012, do you recall why that was? |
WindSoilder
reviewed
Nov 17, 2024
Contributor
WindSoilder
left a comment
WindSoilder
left a comment
There was a problem hiding this comment.
Thank you for the pr! Let's wait the response from @dmatos2012
Contributor
|
if it breaks something we can revert. dmatos doesn't seem to be around. |
Contributor
|
Sorry for the late reply, even after merged, but this was so long ago I do not recall why it was disabled. Normally, I would have left a comment explaining why, so either a) It was disabled by accident which I doubt or most likely 2) There was a particular behavior back then that broke it and/or was also a known behavior in the In any case, if it doesnt fail now, then lets go for it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables some tests that were disabled on macos.
We shall see if the CI passes. (Update: CI has passed.)
User-Facing Changes
Should be no user-facing changes as only a test-file is modified.
Tests + Formatting
Test coverage should increase