-
Notifications
You must be signed in to change notification settings - Fork 2k
add from ndnuon and to ndnuon to stdlib
#14334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add from ndnuon and to ndnuon to stdlib
#14334
Conversation
|
i couldn't try the tests locally so let's see if the CI is happy 😏 |
|
omg i did not export the commands 🤣 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested personally, but the code and tests look good overall. Just some minor suggestions on the comment/doc wording.
| lines | each { from nuon } | ||
| } | ||
|
|
||
| # Convert structured data to NDNUON, i.e. newline-delimited NUON |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| # Convert structured data to NDNUON, i.e. newline-delimited NUON | |
| # Convert structured data to NDNUON (newline-delimited NUON) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in 0e7e3c0
Co-authored-by: Douglas <[email protected]>
here is an example 😉 running ls | first 3 | reject modifiedgives {name: CITATION.cff, type: file, size: 812b}
{name: CODE_OF_CONDUCT.md, type: file, size: 3444b}
{name: CONTRIBUTING.md, type: file, size: 11224b} |
WindSoilder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I think it's good to go
|
noice, thanks @WindSoilder for the merge 🙏 |
Description
i was playing with the NDNUON format and using local definitions of
from ndnuonandto ndnuonbut then i thought they could live in the standard library next tofrom ndjsonandto ndjson😋User-Facing Changes
users can now add the following to their configs and get NDNUON ready to go
Tests + Formatting
i did simply mimic the tests for
from ndjsonandto ndjson, i hope it's fine since the recent big change to the standard libraryAfter Submitting