Update packet.py #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
should be self.session.readvar
ntpsec-bot
pushed a commit
that referenced
this pull request
Jun 12, 2022
Otherwise, ntpd crashes from time to time with the following stack trace: #0 0x00007f5763bfac4d in readv () from /lib64/libc.so.6 #1 0x00007f5763c48b4c in __readvall () from /lib64/libc.so.6 #2 0x00007f5763c467ed in nscd_gethst_r () from /lib64/libc.so.6 #3 0x00007f5763c46c0d in __nscd_gethostbyname2_r () from /lib64/libc.so.6 #4 0x00007f5763c15a2a in gethostbyname2_r () from /lib64/libc.so.6 #5 0x00007f5763bed3ca in gaih_inet.constprop () from /lib64/libc.so.6 #6 0x00007f5763bee225 in getaddrinfo () from /lib64/libc.so.6 #7 0x000055fcf0ad6544 in open_TCP_socket () #8 0x000055fcf0ad79b4 in nts_probe () #9 0x000055fcf0ac37c4 in dns_lookup () #10 0x00007f5763b8205a in start_thread () from /lib64/libc.so.6 #11 0x00007f5763c05d1c in clone3 () from /lib64/libc.so.6 Signed-off-by: Maciej S. Szmigiero <[email protected]>
|
Hi @brendanbank, thanks for submitting this bugfix. GitLab is our primary forge. Would you please do us a favor and submit this PR at https://gitlab.com/NTPsec/ntpsec/-/merge_requests? |
|
Please confirm that this issue has been resolved since 2021-02-01T18:30:23Z. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Peer object, readvars calls self.session.readvars however readvars does not exists in self.session. This should be self.session.readvar