-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Replace viminfo with ShaDa files #2506
Conversation
938455a
to
a3fd0ac
Compare
@@ -7458,7 +7462,7 @@ A jump table for the options with a short description can be found at |Q_op|. | |||
edited. | |||
<1000 Contents of registers (up to 1000 lines each) will be | |||
remembered. | |||
s100 Registers with more than 100 Kbyte text are skipped. | |||
s100 Items occupying more then 102 400 bytes are skipped. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
102 400 is very unusual in U.S. 100 KiB would be better.
6d635a1
to
e2c374b
Compare
1824689
to
657ca52
Compare
3e385c3
to
48a4399
Compare
02e11d1
to
271b1c2
Compare
It leads to a memory leak as well. May overwrite wms->jumps_size.
Problem that led to this skip was fixed in [neovim#3309][1]. [1]: neovim@0a116c8
Errors happens under following conditions: 1. Jump/change list is full. 2. New jump/change list item should go between some of the old ones.
- Remove unused variables. - Do not use helpers.nvim_feed in most cases. - Do not use helpers.nvim and helpers.nvim_eval at all. - Add helpers.funcs and helpers.\*meths special tables. Indexing such table creates functions which call helpers.call or helpers.nvim (and similar) with first argument equal to table index.
Should protect against neovim#3431
They currently cost only one redirect in help file, which will hopefully cause user to review his settings. By the time deprecated option and commands are removed I expect ShaDa files be more useful then currently: specifically this format was designed also to make it possible to have zsh-style history sharing options somewhere in the future which were mentioned in #999. |
Replace viminfo with ShaDa files
👍 Congrats, everyone! |
👍 great work |
Awesome job guys!! |
👍 great job! |
This PR contains replacement for the viminfo file discussed in #999.
s
item size limit.s
item size limit being used when merging for “foreign” items..tmp.b
when.tmp.a
already exists..tmp.z
when.tmp.a
….tmp.x
already exist..tmp.a
….tmp.z
files exist.#if 0
in a ShaDa file forreference).