Backport build fixes for gcc-10 #12142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of declaring an enum, this creates a global variable. As gcc10 uses -fno-common by default, global variables declared with the same name more than once is not allowed anymore revealing this issue. Each time this header is included, we define the enum name as a global variable. See also https://bugzilla.redhat.com/show_bug.cgi?id=1799680
Instead of declaring an enum, this creates a global variable. As gcc10 uses -fno-common by default, global variables declared with the same name more than once is not allowed anymore revealing this issue. Each time this header is included, we define the enum name as a global variable. See also https://bugzilla.redhat.com/show_bug.cgi?id=1799680
Instead of declaring an enum, this creates a global variable. As gcc10 uses -fno-common by default, global variables declared with the same name more than once is not allowed anymore revealing this issue. Each time this header is included, we define the enum name as a global variable. See also https://bugzilla.redhat.com/show_bug.cgi?id=1799680
…g_events gcc10 builds with -fno-common by default. This mean you can't define a global variable with the same name twice. See also https://bugzilla.redhat.com/show_bug.cgi?id=1799680
As gcc10 uses -fno-common by default, global variables declared with the same name more than once is not allowed anymore revealing this issue. We need to define it as extern to access it. See also https://bugzilla.redhat.com/show_bug.cgi?id=1799680
jamessan
added a commit
that referenced
this pull request
Aug 5, 2020
Maintenance release for v0.4.x series. FIXES: fd02e63 #12701 ui: fix problem with sattr_T overflow 3e3002b #12710 fs: Ensure FileInfo struct is initialized e4629f2 #12496 main.c: fix hang issue with recoverymode #12520 f558af8 #12209 fixed hang issue with --headless and -r option specified cda1190 #12180 TUI: block signals on suspend 8399f73 #12142 Fix issues revealed by gcc10 setting -fno-common by default 5e47cf2 netrw.vim: do not save +/* registers 5d41bfc #11907 quickfix.c: Fix vimgrep regression 641e229 #11903 screen: add missing redraws after a message 47bd62c loop_close: close all handles d273036 loop_close: call uv_stop(), fix bug 284b398 #11821 loop_close: timout after 2 seconds 1b2666c messages: echo "line1\r\nline2" should not clear line1 1bf90bf #11651 API: fix crash on copy_object(kObjectTypeWindow) fafd636 #11566 libcallnr: Use int, not int64_t, as the return type for Vim compat 972dd75 #11460 win_line: Fix crash with 'rightleft' in :terminal 4c48cf3 f_getenv/setenv: Access v_special when v_type is VAR_SPECIAL 2cd1ff7 #11360 paste: Select-mode, Visual-mode
qvacua
added a commit
to qvacua/neovim
that referenced
this pull request
Aug 12, 2020
NVIM v0.4.4 Maintenance release for v0.4.x series. FIXES: fd02e63 neovim#12701 ui: fix problem with sattr_T overflow 3e3002b neovim#12710 fs: Ensure FileInfo struct is initialized e4629f2 neovim#12496 main.c: fix hang issue with recoverymode neovim#12520 f558af8 neovim#12209 fixed hang issue with --headless and -r option specified cda1190 neovim#12180 TUI: block signals on suspend 8399f73 neovim#12142 Fix issues revealed by gcc10 setting -fno-common by default 5e47cf2 netrw.vim: do not save +/* registers 5d41bfc neovim#11907 quickfix.c: Fix vimgrep regression 641e229 neovim#11903 screen: add missing redraws after a message 47bd62c loop_close: close all handles d273036 loop_close: call uv_stop(), fix bug 284b398 neovim#11821 loop_close: timout after 2 seconds 1b2666c messages: echo "line1\r\nline2" should not clear line1 1bf90bf neovim#11651 API: fix crash on copy_object(kObjectTypeWindow) fafd636 neovim#11566 libcallnr: Use int, not int64_t, as the return type for Vim compat 972dd75 neovim#11460 win_line: Fix crash with 'rightleft' in :terminal 4c48cf3 f_getenv/setenv: Access v_special when v_type is VAR_SPECIAL 2cd1ff7 neovim#11360 paste: Select-mode, Visual-mode
glensc
added a commit
to pld-linux/neovim
that referenced
this pull request
Nov 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
-fno-commonwhen available and fix the issues it caught.Original PR: #11890