Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes in the documentation #188

Merged
merged 2 commits into from
Oct 22, 2019
Merged

Conversation

hoijui
Copy link
Contributor

@hoijui hoijui commented Oct 16, 2019

No description provided.

Copy link
Owner

@neithernut neithernut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about some of the changes. However, I'm not a native English speaker, so they may well be fine.

doc/caveats.md Show resolved Hide resolved
doc/caveats.md Outdated Show resolved Hide resolved
doc/caveats.md Outdated
@@ -28,12 +28,11 @@ cross-platform notification of events in git repositories (e.g. pushes).
Using such a mechanism, contributors could notify a project maintainer about
changes in their public repositories, including issues or messages, via a public
API. A maintainer could set up automated fetches of new issues, importing new
issues and messages. This is, however unrelated and still work in progress.
issues and messages. This is however, unrelated and still work in progress.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My intuition tells me to put a comma before and after the "however".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm... it starts to get complicated then..
What if we take the "however" to the front of the sentence?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did that.

@neithernut
Copy link
Owner

Thanks for your contribution.

Copy link
Owner

@neithernut neithernut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, thanks for the contribution.

@neithernut neithernut merged commit 0c6ea38 into neithernut:master Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants