macOS: Use objc2 crates
#58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
94 tasks
These replace the `objc` family of crates, and provide a bunch of improvements on top. Improvements that we use in `native-dialog`: - We no longer need to call `msg_send!`, (almost) all methods have automatically generated bindings in `objc2-foundation`. - AppKit bindings are provided in `objc2-app-kit`, so we no longer need to define `NSEdgeInsets`, `NSOpenPanel` and such manually. - `bool` is handled automatically, no need for the `objc_bool` conversion routine. - `declare_class!` is used to create the `DropdownAction` helper class. For this initial transition, I decided to keep the `I...` extension traits around, to make the diff in `src/dialog_impl/mac/file.rs` minimal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These replace the
objcfamily of crates, and provide a bunch of improvements on top, especially wrt. correct memory management.Improvements that we use in
native-dialog:msg_send!, (almost) all methods have automatically generated bindings inobjc2-foundation.objc2-app-kit, so we no longer need to defineNSEdgeInsets,NSOpenPaneland such manually.boolis handled automatically, no need for theobjc_boolconversion routine.declare_class!is used to create theDropdownActionhelper class.For this initial transition, I decided to keep the
I...extension traits around, to make the diff insrc/dialog_impl/mac/file.rsminimal.In the future, the
MainThreadMarkertype could be used to easily assert that things are happening on the main thread, to prevent issues such as #36.