Work/dp catalog #2713
Merged
Work/dp catalog #2713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
LeStarch
reviewed
Dec 5, 2024
bocchino
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
Looks good to me! Here are my comments.
Not Blocking for This PR
- In
configure, the partitioning of memory into three pieces uses reinterpret cast on the address of an out-of-bounds array element, and it may not respect alignment requirements. This kind of code should do array access on the underlying byte buffer (so it's in bounds), it should use placement new to create the arrays, and it should respect alignment requirements. - There aren't enough assertions, particularly before pointer dereference
->.
To Fix for this PR If Possible
- Add comments to
configureto explain what is going on: (a) We are sizing a triple of arrays as an array of triples. (b) We are using array indexing to compute the address after the end of the array. - For consistency, remove the explicit
closeoperation inloadStateFile. In two other places the implicit operation is used.
LeStarch
approved these changes
Dec 11, 2024
|
|
||
| // insert entry into sorted list. if can't insert, quit | ||
| if (not this->insertEntry(this->m_dpList[this->m_numDpRecords])) { | ||
| if (not this->insertEntry(entry)) { |
|
|
||
| // if the tree is empty, add the first entry | ||
| if (this->m_dpTree == nullptr) { | ||
| this->allocateNode(this->m_dpTree,entry); |
There was a problem hiding this comment.
Must fix. Specifically since it is your return value.
| DpCatalog::CheckStat DpCatalog::checkLeftRight(bool condition, DpBtreeNode* &node, const DpStateEntry& newEntry) { | ||
| if (condition) { | ||
| if (node->left == nullptr) { | ||
| if (!this->allocateNode(node->left,newEntry)) { |
| } | ||
| } else { | ||
| if (node->right == nullptr) { | ||
| if (!this->allocateNode(node->right,newEntry)) { |
LeStarch
added
the
Breaking Changes
This was referenced Dec 11, 2024
|
Missing return value checks:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
A description of the changes contained in the PR.
Rationale
A rationale for this change. e.g. fixes bug, or most projects need XYZ feature.
Testing/Review Recommendations
Fill in testing procedures, specific items to focus on for review, or other info to help the team verify these changes are flight-quality.
Future Work
Note any additional work that will be done relating to this issue.