silence deprecation warning by replacing sprintf with snprintf #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pfft, all 12 years I've been into this project, the Microsoft Visual C++ complained about this. Yet the suggested code change is done implicitly by using define |
|
According to cppreference.com, this change may also hurt portability. I guess the time has come to start detecting availability of C++11 in the library build system, so that we might make both the legacy and new worlds live in peace... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
latest Xcode gives out warnings that sprintf is deprecated because of security reasons. Quick silence of this warning is by replacing sprintf with snprintf.