Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Account] Fix SignInButton UI #4421

Merged
merged 1 commit into from
Nov 15, 2024
Merged

[Account] Fix SignInButton UI #4421

merged 1 commit into from
Nov 15, 2024

Conversation

bharatkashyap
Copy link
Member

@bharatkashyap bharatkashyap commented Nov 15, 2024 •
edited
Loading

@bharatkashyap bharatkashyap added the bug 🐛 Something doesn't work label Nov 15, 2024
@prakhargupta1
Copy link
Member

Before:
Screenshot 2024-11-15 at 12 42 42 PM

After:
Screenshot 2024-11-15 at 12 41 41 PM

@bharatkashyap bharatkashyap merged commit 320b923 into mui:master Nov 15, 2024
13 of 14 checks passed
apedroferreira
apedroferreira reviewed Nov 18, 2024
View reviewed changes
packages/toolpad-core/src/Account/SignInButton.tsx
@@ -25,6 +25,8 @@ export /**
sx={{
textTransform: 'capitalize',
filter: 'opacity(0.9)',
width: '50%',
margin: (theme) => `${theme.spacing(1)} auto`,
Copy link
Member

@apedroferreira apedroferreira Nov 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might have just added a margin but this looks ok too.
Also maybe just mh: 1 to avoid using a function + interpolating the string.

Copy link
Member Author

@bharatkashyap bharatkashyap Nov 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also maybe just mh: 1 to avoid using a function + interpolating the string.

You're right, I'll add this in a separate PR Turns out my: 1 is not the same as my: (theme) => theme.spacing(1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apedroferreira apedroferreira apedroferreira left review comments

@prakhargupta1 prakhargupta1 prakhargupta1 approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Account] Broken UI when placed in sidebar footer and signed out
3 participants
@bharatkashyap @prakhargupta1 @apedroferreira