Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] docs: input.label in SlotsSignIn #4157

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Conversation

djedu28
Copy link
Contributor

@djedu28 djedu28 commented Sep 28, 2024

The "input" component had the label="Username", however with email and name="email" type validation.

I corrected the label to represent the content, which is "email"

https://deploy-preview-4157--mui-toolpad-docs.netlify.app/toolpad/core/react-sign-in-page/#slots

  • I've read and followed the contributing guide on how to create great pull requests.
  • I've updated the relevant documentation for any new or updated feature.
  • I've linked relevant GitHub issue with "Closes #".
  • I've added a visual demonstration in the form of a screenshot or video.

The "input" component had the label="Username", however with email and name="email" type validation.

I corrected the label to represent the content, which is "email"

Signed-off-by: Eduardo Santos <[email protected]>
The "input" component had the label="Username", however with email and name="email" type validation.

I corrected the label to represent the content, which is "email"

Signed-off-by: Eduardo Santos <[email protected]>
@Janpot Janpot added docs Improvements or additions to the documentation bug 🐛 Something doesn't work labels Sep 28, 2024
@Janpot Janpot requested review from bharatkashyap and removed request for bharatkashyap September 28, 2024 06:40
@Janpot Janpot removed the bug 🐛 Something doesn't work label Sep 28, 2024
Copy link
Member

@bharatkashyap bharatkashyap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bharatkashyap bharatkashyap merged commit dfea5a7 into mui:master Sep 30, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants