Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Add passkey provider support and example #4063

Merged
merged 30 commits into from
Oct 18, 2024
Merged

[core] Add passkey provider support and example #4063

merged 30 commits into from
Oct 18, 2024

Conversation

bharatkashyap
Copy link
Member

@bharatkashyap bharatkashyap commented Sep 9, 2024 •
edited
Loading

@bharatkashyap bharatkashyap added the enhancement This is not a bug, nor a new feature label Sep 9, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 9, 2024
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Sep 9, 2024
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Sep 12, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 13, 2024
@bharatkashyap bharatkashyap marked this pull request as ready for review September 13, 2024 13:45
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 15, 2024
apedroferreira
apedroferreira approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@apedroferreira apedroferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems all good!
Just 2 non-blocking comments/suggestions but not 100% sure about them as you might have had a reason to do things that way.

examples/core-auth-nextjs-passkey/src/auth.ts Outdated Show resolved Hide resolved
docs/data/toolpad/core/components/sign-in-page/PasskeySignInPage.tsx Show resolved Hide resolved
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 17, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 22, 2024
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Sep 30, 2024
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Oct 10, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 14, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 17, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 18, 2024
@bharatkashyap bharatkashyap removed the request for review from mnajdova October 18, 2024 17:20
@bharatkashyap bharatkashyap merged commit 0610dcf into mui:master Oct 18, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apedroferreira apedroferreira apedroferreira approved these changes

@Janpot Janpot Janpot approved these changes

Assignees
No one assigned
Labels
enhancement This is not a bug, nor a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[auth] Add passkey support to the credentials provider
3 participants
@bharatkashyap @Janpot @apedroferreira