Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Fix issues with DashboardLayout in Toolpad Core homepage #3893

Merged
merged 8 commits into from
Aug 5, 2024
Merged

[docs] Fix issues with DashboardLayout in Toolpad Core homepage #3893

merged 8 commits into from
Aug 5, 2024

Conversation

apedroferreira
Copy link
Member

@apedroferreira apedroferreira commented Aug 5, 2024 •
edited
Loading

Noticed some issues with the dashboard layout in the Toolpad Core homepage:

  • When the mobile menu opens the app bar becomes empty
  • Unnecessary spacing above PageContainer
  • Spacing was off in code examples and did not match the actual example code

This PR should fix these issues - it's just not fixing the fact that the grid inside the PageContainer is changing width when the menu is expanded - if that's not addressed in #3848 I can try to fix that too.

https://deploy-preview-3893--mui-toolpad-docs.netlify.app/toolpad/core/

Screen.Recording.2024-08-05.at.13.07.47.mov

@apedroferreira apedroferreira added docs Improvements or additions to the documentation bug 🐛 Something doesn't work labels Aug 5, 2024
@apedroferreira apedroferreira self-assigned this Aug 5, 2024
@apedroferreira apedroferreira marked this pull request as ready for review August 5, 2024 12:00
@apedroferreira apedroferreira requested a review from a team August 5, 2024 12:11
@Janpot
Copy link
Member

Janpot commented Aug 5, 2024

  • There is a strange spacing around the application that doesn't feel right
    Screenshot 2024-08-05 at 14 44 18
    Would probably look better as

    Screenshot 2024-08-05 at 14 47 14

  • There's a scrollbar that doesn't follow the theme

@apedroferreira
Copy link
Member Author

There is a strange spacing around the application that doesn't feel right

Added a fix to remove this space from all 3 items that use iframes.

There's a scrollbar that doesn't follow the theme

Let's try to fix this one separately along with:

@Janpot Janpot merged commit 07781cb into mui:master Aug 5, 2024
14 checks passed
@apedroferreira apedroferreira deleted the fix-dashboard-layout-in-homepage branch August 5, 2024 20:10
@apedroferreira apedroferreira mentioned this pull request Aug 7, 2024
Merged
@oliviertassinari oliviertassinari added the component: layout This is the name of the generic UI component, not the React module! label Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Janpot Janpot Janpot approved these changes

Assignees

@apedroferreira apedroferreira

Labels
bug 🐛 Something doesn't work component: layout This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apedroferreira @Janpot @oliviertassinari