[docs] Improve Core tutorial #3874
Conversation
I did this intentionally, to show how the composability works together with app router layouts |
| import { LoadingButton } from '@mui/lab'; | ||
| import { Box } from '@mui/material'; | ||
|
|
||
| export default function NavigateButton() { |
There was a problem hiding this comment.
I think it doesn't make sense to make this a separate file/component? Seems too specific, better for it to be in the intro page(s) directly?
There was a problem hiding this comment.
This is a client component, so – I could be wrong – it must be in its own file with "use client" at the top
There was a problem hiding this comment.
I think you can have 'use client' as the first line inside the component?
But if in terms of file structure you think this makes more sense anyway it's not a big deal!
| title: 'Page', | ||
| icon: <DashboardIcon />, | ||
| }, | ||
| ]; | ||
|
|
||
| export default function RootLayout({ children }: Readonly<{ children: React.ReactNode }>) { | ||
| return ( | ||
| <html lang="en"> | ||
| <html lang="en" data-toolpad-color-scheme="light"> |
There was a problem hiding this comment.
Matching the playground should be good here!
There was a problem hiding this comment.
I think the playground app also contains the same attribute in the app/layout.tsx file, isn'it? That's what I can see here: https://github.com/mui/mui-toolpad/blob/master/playground/nextjs/src/app/layout.tsx#L27
There was a problem hiding this comment.
Yep that's what I meant, was just confirming that it seems good!
The issue with this was that adding a second page required adding a |
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
Usually, the features of the CLI should drive the tutorial content, not the other way around. But I'm not heavily against the change, we can go with it for now. |
core-tutorialexample in sync with the docs pagecore-tutorialto make the tutorial work better, for instance: AddPageContainertodashboard/layoutinstead ofdashboard/page/layoutNavigateButtonto the example to improve interactivity on the first button in dev mode:before.mov
after.mov