Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Fix core example #3847

Merged
merged 5 commits into from
Jul 28, 2024
Merged

[cli] Fix core example #3847

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
aedd71d
fix: Skips install on `--example`
bharatkashyap Jul 26, 2024
305cc1f
fix: eslint causing `ERESOLVE`, install example deps, clean up
bharatkashyap Jul 26, 2024
096ec8f
fix: CI
bharatkashyap Jul 26, 2024
baf9918
fix: Jan review
bharatkashyap Jul 27, 2024
3dd9132
Merge branch 'master' of github.com:mui/mui-toolpad into fix/cta-exam…
bharatkashyap Jul 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: Skips install on --example
  • Loading branch information
@bharatkashyap
bharatkashyap committed Jul 26, 2024
commit aedd71d93a750bedb4d2ae381cba2b2b6e024fb9
13 changes: 13 additions & 0 deletions packages/create-toolpad-app/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,19 @@ const run = async () => {
// If the user has provided an example, download and extract it
if (args.example) {
await downloadAndExtractExample(absolutePath, args.example);
// eslint-disable-next-line no-console
console.log(`${chalk.cyan('info')} - Installing dependencies`);
// eslint-disable-next-line no-console
console.log();
await execa(packageManager, ['install'], { stdio: 'inherit', cwd: absolutePath });
// eslint-disable-next-line no-console
console.log();
// eslint-disable-next-line no-console
console.log(
`${chalk.green('success')} - Installed "${args.example}" at ${chalk.cyan(absolutePath)}`,
);
// eslint-disable-next-line no-console
console.log();
}
// If the core flag is set, create a new project with Toolpad Core
else if (coreFlag) {
Expand Down